Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
From: kosssi <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-53-cordova-plugin-globalization@git.apache.org>
In-Reply-To: <git-pr-53-cordova-plugin-globalization@git.apache.org>
Subject: [GitHub] cordova-plugin-globalization issue #53: CB-11154: (Android, iOS) Add IANA ti...
Content-Type: text/plain
Message-Id: <20170105091318.12680DF9F9@git1-us-west.apache.org>
Date: Thu,  5 Jan 2017 09:13:18 +0000 (UTC)
archived-at: Thu, 05 Jan 2017 09:13:20 -0000

Github user kosssi commented on the issue:

    https://github.com/apache/cordova-plugin-globalization/pull/53
  
    Thanks @shazron 
    
    - [x] update https://github.com/MSOpenTech/cordova-plugin-globalization to https://github.com/apache/cordova-plugin-globalization
    - [x] I fix timezone test:
    
    ```
                    expect(a.timezone).toBeDefined();
                    expect(typeof a.timezone).toBe('string');
                    if (!isBrowser) {
                        // The browser platform partially supports 'timezone'. Only Chrome returns 'timezone' property.
                        // Its format is "Part of the world/{City}". Other browsers return empty string.
                        // https://github.com/MSOpenTech/cordova-plugin-globalization/blob/21f8a0ffa5aa2497ee970b6b5092b4c65fc4bf7e/README.md#browser-quirks-4
                        expect(a.pattern.length > 0).toBe(true);
                    }
                    expect(a.timezone.length > 0).toBe(true);
    ```
    
    to
    
    ```
                    expect(a.timezone).toBeDefined();
                    expect(typeof a.timezone).toBe('string');
                    if (!isBrowser) {
                        // The browser platform partially supports 'timezone'. Only Chrome returns 'timezone' property.
                        // Its format is "Part of the world/{City}". Other browsers return empty string.
                        // https://github.com/apache/cordova-plugin-globalization/blob/21f8a0ffa5aa2497ee970b6b5092b4c65fc4bf7e/README.md#browser-quirks-4
                        expect(a.timezone.length > 0).toBe(true);
    }
    ```
    
    - [x] Add test to timezone_iana


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org