cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From daserge <...@git.apache.org>
Subject [GitHub] cordova-lib pull request #515: CB-12383 Fix cordova_plugins metadata definit...
Date Tue, 24 Jan 2017 10:41:42 GMT
GitHub user daserge opened a pull request:

    https://github.com/apache/cordova-lib/pull/515

    CB-12383 Fix cordova_plugins metadata definition

    Define parent object first
    [Jira issue](https://issues.apache.org/jira/browse/CB-12383)
    
    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    Tested on windows and android with this code:
    ```
        onDeviceReady: function() {
            this.receivedEvent('deviceready');
    
            navigator.notification.alert(cordova.require("cordova/plugin_list").metadata);
        },
    ```
    
    ### What does this PR do?
    Makes `require("cordova/plugin_list").metadata` also available with browserify.
    
    ### What testing has been done on this change?
    Manual tests, run cordova-lib auto tests
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/daserge/cordova-lib CB-12383

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-lib/pull/515.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #515
    
----
commit c23f20f3600330c722926e233c0a2dd893f8b25c
Author: daserge <v-seshak@microsoft.com>
Date:   2017-01-24T09:52:44Z

    CB-12383 Fix cordova_plugins metadata definition
    Define parent object first

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message