cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sryze <...@git.apache.org>
Subject [GitHub] cordova-lib pull request #514: CB-12337 Resolve symbolic links in project ro...
Date Mon, 09 Jan 2017 20:06:09 GMT
GitHub user sryze opened a pull request:

    https://github.com/apache/cordova-lib/pull/514

    CB-12337 Resolve symbolic links in project root

    ### Platforms affected
    All?
    
    ### What does this PR do?
    
    If project path had symlinks its absolute value was different from that returned by `__dirname`
inside project-local modules. So when it was joined with various dirs like `www` the two absolute
paths were merged resulting in an invalid path.
    
    This should make commands like `cordova emulate android` work on Windows for projects
with symlinks in path.
    
    There may be other places where similar measures need to be taken.
    
    ### What testing has been done on this change?
    Tested locally on my project.
    
    ### Checklist
    - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sryze/cordova-lib cb-12337

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-lib/pull/514.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #514
    
----
commit dff7e78ddf87d90c09a9fd265b76e083cbf45869
Author: Sergey Zolotarev <sryze@yandex.com>
Date:   2017-01-09T19:51:57Z

    CB-12337 Resolve symbolic links in project root
    
    If project path had symlinks its absolute value was different from that
    returned by __dirname inside project-local modules. So when it was joined
    with various dirs like 'www' the two absolute paths were merged resulting
    in an invalid path.
    
    This should make 'cordova emulate android' work on Windows for projects
    with symlinks in path.
    
    There may be other places where similar measures need to be taken.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message