cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sryze <...@git.apache.org>
Subject [GitHub] cordova-plugin-camera pull request #251: CB-12368: Fix wrong permission requ...
Date Thu, 26 Jan 2017 19:47:35 GMT
GitHub user sryze opened a pull request:

    https://github.com/apache/cordova-plugin-camera/pull/251

    CB-12368: Fix wrong permission request on Android

    ### Platforms affected
    Android
    
    ### What does this PR do?
    The plugin was requesting permission for camera instead of external storage.
    
    ### What testing has been done on this change?
    Tested on Android 6 & 7.
    
    ### Checklist
    - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sryze/cordova-plugin-camera cb-12368

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-camera/pull/251.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #251
    
----
commit bfa48b9f13009d1b944e1f239a3468a386b263a2
Author: Sergey Zolotarev <sryze@yandex.com>
Date:   2017-01-26T19:41:56Z

    CB-12368: Fix wrong permission request on Android
    
    The plugin was requesting permission for camera instead of external
    storage.
    
    Surprisingly enough this fixed CB-12368.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message