cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From reidab <...@git.apache.org>
Subject [GitHub] cordova-plugin-inappbrowser pull request #209: CB-12366: (ios) Reduce tmpWin...
Date Thu, 19 Jan 2017 00:37:56 GMT
GitHub user reidab opened a pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/209

    CB-12366: (ios) Reduce tmpWindow level to prevent overlapping statusbar

    ### Platforms affected
    
    iOS
    
    ### What does this PR do?
    
    Reduces the window level of the `tmpWindow` introduced in #187 to `UIWindowLevelNormal`.
With the window at `UIWindowLevelAlert`, I'm seeing it obscure the iOS status bar when presented.
    
    @manucorporat I'd be curious to know if the higher window level is required to solve the
issues you were looking at in #187.
    
    ### What testing has been done on this change?
    
    Testing in Simulator iOS 10, Device iOS10.
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/reidab/cordova-plugin-inappbrowser CB-12366

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/209.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #209
    
----
commit 32243b351edb808bd85fa02dc61ecb52d6a3a33a
Author: Reid Beels <mail@reidbeels.com>
Date:   2017-01-19T00:33:27Z

    CB-12366: (ios) Reduce tmpWindow level to prevent overlapping statusbar

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message