cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From spongessuck <...@git.apache.org>
Subject [GitHub] cordova-plugin-inappbrowser pull request #206: CB-12320: (iOS) WIP Add suppo...
Date Thu, 05 Jan 2017 18:58:56 GMT
GitHub user spongessuck opened a pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/206

    CB-12320: (iOS) WIP Add support for navigation bar 

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    iOS
    
    ### What does this PR do?
    - Adds support for using the iOS navigation bar as an alternative to a top-positioned
toolbar. This makes the toolbar look much more native. When `navigationbar=yes` is set, it
puts the toolbar buttons in the navigation bar and hides the toolbar.
    - Allows for the navigation buttons to be hidden using `navigationbuttons=no`.
    - Allows for adding a title to the navigation bar using `navigationbartitle`.
    
    ### What testing has been done on this change?
    Tested to make sure the new options are respected. I'm not sure what kind of automated
tests might be required/have to be changed.
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.
    
    ### Issues
    - Location bar doesn't appear correctly when `toolbarposition=top` is set.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/spongessuck/cordova-plugin-inappbrowser master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/206.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #206
    
----
commit 429402406298d772e01e9e959cbcb2d9d0b21fbf
Author: Gregory McGee <spongessuck@gmail.com>
Date:   2017-01-05T18:52:12Z

    CB-12320: (iOS) Add support for navigation bar

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message