cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From darron1217 <...@git.apache.org>
Subject [GitHub] cordova-plugin-inappbrowser pull request #205: Cb 9148 (android) Add support...
Date Tue, 03 Jan 2017 05:56:06 GMT
GitHub user darron1217 opened a pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/205

    Cb 9148 (android) Add support for input[type=file] to InAppBrowser!

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    Android
    
    ### What does this PR do?
    This PR enables default action for input[type=file] at inappbrowser.
    Which means, input[type=file] opens native file chooser in android.
    
    ### What testing has been done on this change?
    I tested input[type=file] element to open file chooser.
    And it worked beautifully :D
    
    ### Checklist
    - [ v ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [ v ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving
file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ X ] Added automated test coverage as appropriate for this change.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/darron1217/cordova-plugin-inappbrowser CB-9148

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/205.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #205
    
----
commit 4d40e4221f78e6de2a3db1770f98ceaafb1cecaf
Author: 박관영 <jay8585@naver.com>
Date:   2017-01-03T05:09:17Z

    Add Support for input[type=file] File Chooser

commit 5ab2e9b4b46cae63d59016c447af218b6fc0cb6e
Author: 박관영 <jay8585@naver.com>
Date:   2017-01-03T05:20:50Z

    Add Support for input[type=file] File Chooser

commit 0d49f1c96e0137efa885857d90f0f42eea806543
Author: 박관영 <jay8585@naver.com>
Date:   2017-01-03T05:22:59Z

    CB-9148 (android) Add Support for input[type=file] File Chooser

commit d576aa8d05e0a072ac6cd281cb151e330bc63740
Author: 박관영 <jay8585@naver.com>
Date:   2017-01-03T05:28:05Z

    CB-9148 (android) Add Support for input[type=file] File Chooser

commit 31bcd0f118259d546e9298056b9a1c66b947fd90
Author: 박관영 <jay8585@naver.com>
Date:   2017-01-03T05:29:44Z

    CB-9148 (android) Add Support for input[type=file] File Chooser

commit 38882d4ac122459f65bc6ea1fedea67cd1f14b8d
Author: 박관영 <jay8585@naver.com>
Date:   2017-01-03T05:39:25Z

    CB-9148 (android) Add Support for input[type=file] File Chooser

commit cf3adcb9413ca23f1fbdae9f40b4205e40a710ae
Author: 박관영 <jay8585@naver.com>
Date:   2017-01-03T05:40:16Z

    CB-9148 (android) Add Support for input[type=file] File Chooser

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message