cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From alsorokin <...@git.apache.org>
Subject [GitHub] cordova-plugin-file-transfer pull request #171: CB-12336 (android) Do not ca...
Date Tue, 10 Jan 2017 15:25:36 GMT
GitHub user alsorokin opened a pull request:

    https://github.com/apache/cordova-plugin-file-transfer/pull/171

    CB-12336 (android) Do not call win callback if aborted

    ### Platforms affected
    Android
    
    ### What does this PR do?
    Fixes a rare condition on Android when win callback is called even after the `abort()`.
    Added a test to make sure the `aborted` flag is reset correctly at the next download attempt.
    
    ### What testing has been done on this change?
    ~10 test runs on CI
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [x] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/alsorokin/cordova-plugin-file-transfer CB-12336

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-file-transfer/pull/171.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #171
    
----
commit 9093e68de8f27b70af8418b351d6592d8b8abc01
Author: Alexander Sorokin <alexander.sorokin@akvelon.com>
Date:   2017-01-09T16:12:15Z

    CB-12336 (android) Do not call win callback if aborted

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message