cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From happy2discover <...@git.apache.org>
Subject [GitHub] cordova-plugin-media pull request #124: CB-12319: (Android&iOS) Fix bug that...
Date Thu, 05 Jan 2017 05:49:21 GMT
GitHub user happy2discover opened a pull request:

    https://github.com/apache/cordova-plugin-media/pull/124

    CB-12319: (Android&iOS) Fix bug that recorded audio files of Android cannot be played
in iOS with the html <audio> tag

    Make the output file of Android an acc file in order to play the audio file with the html
<audio> tag in iOS:
    1. change OutputFormat from RAW_AMR to AAC_ADTS
    2. change OutputFormat from AMR_NB to AAC
    
    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    
    
    ### What does this PR do?
    
    
    ### What testing has been done on this change?
    
    
    ### Checklist
    - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/happy2discover/cordova-plugin-media master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-media/pull/124.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #124
    
----
commit 62270a07341a115b9eb65e278224b9f9ae3e78c8
Author: happy2discover <happy2discover@users.noreply.github.com>
Date:   2017-01-05T05:37:04Z

    Make the output file of Android an acc file.
    
    In order to play the audio file with the html <audio> tag in iOS:
    1. change OutputFormat from RAW_AMR to AAC_ADTS
    2. change OutputFormat from AMR_NB to AAC

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message