cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From maverickmishra <...@git.apache.org>
Subject [GitHub] cordova-plugin-screen-orientation pull request #10: Update screen orientatio...
Date Wed, 25 Jan 2017 18:51:32 GMT
GitHub user maverickmishra opened a pull request:

    https://github.com/apache/cordova-plugin-screen-orientation/pull/10

    Update screen orientation plugin to w3 spec

    
    
    ### Platforms affected
    iOS, Android,Windows
    
    ### What does this PR do?
    This PR makes the plugin conform to w3 specs
    
    ### What testing has been done on this change?
    Tested on iOS, Android and Windows devices.
    
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/maverickmishra/cordova-plugin-screen-orientation master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-screen-orientation/pull/10.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #10
    
----
commit 1f536ec80e6f54edb618dabc2a0dd7c9b3e62a0e
Author: maverickmishra <vishalmishra0907@gmail.com>
Date:   2017-01-10T00:42:53Z

     working version of screen orientation plugin adhering to w3c specs

commit f8c75e341ae521cd248e9385e6b05bdd3344274d
Author: maverickmishra <vishalmishra0907@gmail.com>
Date:   2017-01-10T01:10:07Z

    improved the orientation change method

commit 050cc069a15a97ec8ff81a03c7dac66340ede61f
Author: Vishal Mishra <maverickmishra@users.noreply.github.com>
Date:   2017-01-10T22:08:13Z

    Removed unused variable assignment

commit 68693cf017440e5931c4cd209d0ec96ea7d2406a
Author: maverickmishra <vishalmishra0907@gmail.com>
Date:   2017-01-10T23:27:38Z

    puts all nativelock handling together

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message