cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vladimir Kotikov (Akvelon)" <v-vlk...@microsoft.com>
Subject Re: plugins and engines
Date Thu, 05 Jan 2017 06:52:23 GMT
Here is another relevant proposal and discussion: https://github.com/cordova/cordova-discuss/pull/30.
I think we’ve agreed to follow this way to “pin” specific plugins’ versions to specific
cordova versions.

Here are some examples:
1. https://github.com/apache/cordova-plugin-inappbrowser/blob/master/package.json#L47-L54
2. https://github.com/litehelpers/Cordova-sqlite-storage/blob/storage-master/package.json#L13-L17

-
Best regards, Vladimir
 

On 1/4/17, 19:21, "julio cesar sanchez" <jcesarmobile@gmail.com> wrote:

    I think we should start testing plugins with cordova-android 4.1.1 as is
    the lower required by Google to publish on Google play. If some plugin
    doesn't compile then increase the engine version to next cordova-android.
    In example, camera plugin doesn't compile with cordova-android 4.1.1.
    
    For cordova-ios we should require at least 3.4.1 as is the version that
    included the 64bit support, required by apple, not sure if they require a
    newer version for some other reason now.
    
    
    El 4 ene. 2017 2:52 p. m., "Filip Maj" <maj.fil@gmail.com> escribió:
    
    > Sounds like a good idea, but how to go about doing it? We probably
    > can't easily, for example, rule out older versions of iOS without
    > someone testing with an old Xcode version.
    >
    > On Tue, Jan 3, 2017 at 5:15 PM, Shazron <shazron@gmail.com> wrote:
    > > Related: https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fissues.apache.org%2Fjira%2Fbrowse%2FCB-6582&data=02%7C01%7Cv-vlkoti%40microsoft.com%7Ce2cfd36143c74c85e24408d434bdb765%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636191436803774697&sdata=Ny5sFt0LDFmoCUyQbYW1%2B%2Flf38Sz2QKpfuFLqNO3aRE%3D&reserved=0
    > > (almost 3 years old...)
    > >
    > > TLDR; we should update the engine tags, with as much granularity as
    > > possible.
    > >
    > > I think we didn't do this because we don't actually know if it *doesn't*
    > > work on an older version (since of course we don't test the current
    > version
    > > with older platform version) and didn't want to unnecessarily restrict a
    > > user from installing it.
    > >
    > > We planned to pin core plugins to a cordova-lib version but we decided to
    > > use engine tags in plugins:
    > > https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fcordova%2Fcordova-discuss%2Fblob%2Fmaster%2Fproposals%2F&data=02%7C01%7Cv-vlkoti%40microsoft.com%7Ce2cfd36143c74c85e24408d434bdb765%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636191436803774697&sdata=2bK2SeDLFC50%2Boo4crA%2Fvj3PqRRcZ0iNcRCOzdcpNvU%3D&reserved=0
    > pinningAndVersioning.md
    > >
    > >
    > > On Tue, Jan 3, 2017 at 12:26 PM, julio cesar sanchez <
    > jcesarmobile@gmail.com
    > >> wrote:
    > >
    > >> I have noticed that most of the plugins don't use the engine tags or
    > have
    > >> them set to cordova 3.0.0 or 3.1.0 which are very old.
    > >>
    > >> As we drop support for old iOS/Android versions when updating
    > cordova-ios
    > >> and cordova-android, what is our policy for iOS/Android versions
    > support in
    > >> plugins?
    > >>
    > >> Right now people can use the plugins on very old versions of iOS or
    > Android
    > >> despite we don't support them on the platforms, as the plugins engines
    > are
    > >> set to 3.0.0 or 3.1.0 on most of them.
    > >>
    > >> Should we start updating the engines to newer cordova versions? or even
    > >> fine grain it to cordova-ios/cordova-android versions?
    > >> I have noticed that we even have engines for iOS versions using
    > apple-ios
    > >> on the engine tag
    > >> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-plugin-wkwebview-&data=02%7C01%7Cv-vlkoti%40microsoft.com%7Ce2cfd36143c74c85e24408d434bdb765%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636191436803774697&sdata=yLXXSTq5hXfxS1yMhOePCv%2F7xLuxpUyzOoTATnUU3bo%3D&reserved=0
    > >> engine/blob/master/plugin.xml#L35
    > >> (but not sure if this really does something as the plugin can be
    > >> installed/used in older iOS versions and what works or doesn't work is
    > >> controlled in the code)
    > >>
    > >> Or just say that the old Android/iOS version is not supported by Cordova
    > >> anymore if someone complains about a plugin not working?
    > >>
    >
    > ---------------------------------------------------------------------
    > To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
    > For additional commands, e-mail: dev-help@cordova.apache.org
    >
    >
    



Mime
View raw message