cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Simon MacDonald <simon.macdon...@gmail.com>
Subject Re: CB-11602: (android) Adds onRestart event support
Date Wed, 25 Jan 2017 07:09:59 GMT
I would be happy to see Splash Screen go back to the platforms as well.

Simon Mac Donald
http://simonmacdonald.com

On Tue, Jan 24, 2017 at 10:56 PM, Joe Bowser <bowserj@gmail.com> wrote:

> OK, time to address the elephant in the room:
>
> Why is the Splashscreen still a plugin?  It was only made a plugin because
> someone wanted to be a purist about plugins, and there's actually no good
> reason for it to not just be built into Cordova.  I used to think
> Splashscreens were dumb and were used to cover up bad loading times, but
> there's a good business case for them since people expect them.
>
> Also, related, Splashscreen on Android needs to be rebuilt anyway.  There's
> numerous bugs with it, and I think adding it back into the platforms might
> actually delete code and simplify things.
>
> I know that we said these exact things before at meetings and wrote them in
> minutes that we posted here, but I think now is probably good time to bring
> this up.
>
> The only reason I don't want to throw this back into Android is because I
> don't want crap ton of PRs in Cordova-Android just all about Splashscreen.
> That said, at least we can get those unit tested and actually make sure
> that 3 second delays are actually 3 seconds and not some random value, and
> other things like that.
>
>
> On Tue, Jan 24, 2017 at 10:47 PM, Jesse <purplecabbage@gmail.com> wrote:
>
> > I would like to see us move towards making this platform level
> > functionality,  The requirements of this API happen mostly outside of the
> > scope of a plugin's lifetime.
> >
> > If we could get to an api that was just, images with the right names are
> > presented when the OS decides to do it, the way all native platforms
> work,
> > I think we would be better off.
> >
> >
> > @purplecabbage
> > risingj.com
> >
> > On Fri, Jan 20, 2017 at 3:28 AM, <daserge@apache.org> wrote:
> >
> > > Hello,
> > >
> > > There's a related issue marked as WontFix [1][2] but as far as I
> > > understand it does not apply to the SplashScreen plugin as it is
> > > initialized on startup (via <param name="onload" value="true"/>).
> > > So the question is - should we add onRestart as it is not fundamentally
> > > different from onStart, which is supported?
> > > Or is there a better/more correct way to do it?
> > >
> > > [1]: https://issues.apache.org/jira/browse/CB-9620
> > > [2]: https://issues.apache.org/jira/browse/CB-9621
> > >
> > > Please let me know if you have any questions or considerations.
> > >
> > > Best regards,
> > > Sergey Shakhnazarov,
> > > Akvelon developer.
> > >
> > > -----Original Message-----
> > > From: Sergey Shakhnazarov [mailto:daserge@apache.org]
> > > Sent: Thursday, January 12, 2017 12:10
> > > To: dev <dev@cordova.apache.org>
> > > Subject: CB-11602: (android) Adds onRestart event support
> > >
> > > Hi guys,
> > >
> > > I've investigated the CB-11602 Splashscreen plugin receives onPause and
> > > hides [1] and realized that the splashscreen plugin currently doesn't
> > > handle onStop->onRestart [2] events properly.
> > > The reason is that we don't have the onRestart event in cordova-android
> > so
> > > I propose to add it [3] and update the splash screen plugin code
> > > accordingly to handle this pause-resume events correctly [4] (i.e.
> > > save/restore the splashscreen state on app switch/device lock).
> > > Please take a look.
> > >
> > > [1]: https://na01.safelinks.protection.outlook.com/?url=https%3A%
> > > 2F%2Fissues.apache.org%2Fjira%2Fbrowse%2FCB-11602&data=02%
> > > 7C01%7Cv-seshak%40microsoft.com%7Cb58575c22fb04ad3c29308d4
> > > 3acabe0f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636198
> > > 089826262946&sdata=ic0pYXcxfToH7eHWkPUktKDgm0aYMhHgfxqhJ8ECS
> > > sU%3D&reserved=0
> > > [2]:
> > > https://na01.safelinks.protection.outlook.com/?url=https%3A%
> > > 2F%2Fdeveloper.android.com%2Freference%2Fandroid%2Fapp%
> > > 2FActivity.html%23onRestart&data=02%7C01%7Cv-seshak%
> > > 40microsoft.com%7Cb58575c22fb04ad3c29308d43acabe0f%7C72f988b
> > > f86f141af91ab2d7cd011db47%7C1%7C0%7C636198089826262946&sdata=Ido%
> > > 2FCxLiFO9fdJxCTb1HvIt9dBo%2BMtIjwUqo6%2FDyPaw%3D&reserved=0()
> > > [3]: https://na01.safelinks.protection.outlook.com/?url=https%3A%
> > > 2F%2Fgithub.com%2Fapache%2Fcordova-android%2Fpull%
> > > 2F353%2Ffiles&data=02%7C01%7Cv-seshak%40microsoft.com%7Cb
> > > 58575c22fb04ad3c29308d43acabe0f%7C72f988bf86f141af91ab2d7cd0
> > > 11db47%7C1%7C0%7C636198089826272954&sdata=mMHBhAcWSuBXgWOVFS
> > > TyX8tV8cikEKfAO4hX95A7Zcs%3D&reserved=0
> > > [4]: https://na01.safelinks.protection.outlook.com/?url=https%3A%
> > > 2F%2Fgithub.com%2Fapache%2Fcordova-plugin-splashscreen%
> > > 2Fpull%2F120%2Ffiles&data=02%7C01%7Cv-seshak%40microsoft.
> > > com%7Cb58575c22fb04ad3c29308d43acabe0f%7C72f988bf86f141af91a
> > > b2d7cd011db47%7C1%7C0%7C636198089826272954&sdata=Xg5ldRRKYwl
> > > UGvbCWMUOzk2HIzWStMJze0jFTzif3A8%3D&reserved=0
> > >
> > > Best regards,
> > > Sergey Shakhnazarov,
> > > Akvelon developer.
> > >
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > > For additional commands, e-mail: dev-help@cordova.apache.org
> > >
> > >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message