cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From daserge <...@git.apache.org>
Subject [GitHub] cordova-lib pull request #515: CB-12383 Fix cordova_plugins metadata definit...
Date Wed, 25 Jan 2017 09:47:02 GMT
Github user daserge commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/515#discussion_r97741534
  
    --- Diff: cordova-lib/src/plugman/browserify.js ---
    @@ -157,8 +157,8 @@ module.exports = function doBrowserify (project, platformApi, pluginInfoProvider
             // instead of generating intermediate file on FS
             var cordova_plugins = new Readable();
             cordova_plugins.push(
    -            'module.exports.metadata = ' + JSON.stringify(pluginMetadata, null, 4) +
';\n' +
    -            'module.exports = ' + JSON.stringify(modulesMetadata, null, 4) + ';\n', 'utf8');
    +            'module.exports = ' + JSON.stringify(modulesMetadata, null, 4) + ';\n' +
    +            'module.exports.metadata = ' + JSON.stringify(pluginMetadata, null, 4) +
';\n', 'utf8');
    --- End diff --
    
    Right. And the behavior differs for normal and browserify cases.
    I.e. in normal case when we are injecting a script element the above code did not result
in `module.exports` being overwritten.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message