cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From alsorokin <...@git.apache.org>
Subject [GitHub] cordova-plugin-file-transfer issue #171: CB-12336 (android) Do not call win ...
Date Fri, 20 Jan 2017 16:46:08 GMT
Github user alsorokin commented on the issue:

    https://github.com/apache/cordova-plugin-file-transfer/pull/171
  
    Hey @filmaj, nice to see you 😄 
    
    Nevermind this test, it was meant to ensure that my changes does not break downloading
two files successively.
    
    The bad news are that the fix is still not working:
    http://cordova-ci.cloudapp.net:8080/job/cordova-periodic-build-TEST/58/PLATFORM=android-4.4,PLUGIN=cordova-plugin-file-transfer/testReport/junit/cordova-plugin-file-transfer-tests.tests%20__.FileTransfer.methods/download/filetransfer_spec_9_should_not_leave_partial_file_due_to_abort/
    
    After some investigation, I think that calling `win` callback after `abort()` is kind
of expected behavior, at least if we've not called`fail` callback yet and the file is ready
or is being saved to disk or anything else.
    
    Going to adapt the spec to expect `fail` callback, but if we receive win, we just make
sure there were no other `fail` callbacks called.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message