cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kosssi <...@git.apache.org>
Subject [GitHub] cordova-plugin-globalization issue #53: CB-11154: (Android, iOS) Add IANA ti...
Date Thu, 05 Jan 2017 09:13:18 GMT
Github user kosssi commented on the issue:

    https://github.com/apache/cordova-plugin-globalization/pull/53
  
    Thanks @shazron 
    
    - [x] update https://github.com/MSOpenTech/cordova-plugin-globalization to https://github.com/apache/cordova-plugin-globalization
    - [x] I fix timezone test:
    
    ```
                    expect(a.timezone).toBeDefined();
                    expect(typeof a.timezone).toBe('string');
                    if (!isBrowser) {
                        // The browser platform partially supports 'timezone'. Only Chrome
returns 'timezone' property.
                        // Its format is "Part of the world/{City}". Other browsers return
empty string.
                        // https://github.com/MSOpenTech/cordova-plugin-globalization/blob/21f8a0ffa5aa2497ee970b6b5092b4c65fc4bf7e/README.md#browser-quirks-4
                        expect(a.pattern.length > 0).toBe(true);
                    }
                    expect(a.timezone.length > 0).toBe(true);
    ```
    
    to
    
    ```
                    expect(a.timezone).toBeDefined();
                    expect(typeof a.timezone).toBe('string');
                    if (!isBrowser) {
                        // The browser platform partially supports 'timezone'. Only Chrome
returns 'timezone' property.
                        // Its format is "Part of the world/{City}". Other browsers return
empty string.
                        // https://github.com/apache/cordova-plugin-globalization/blob/21f8a0ffa5aa2497ee970b6b5092b4c65fc4bf7e/README.md#browser-quirks-4
                        expect(a.timezone.length > 0).toBe(true);
    }
    ```
    
    - [x] Add test to timezone_iana


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message