cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From infil00p <...@git.apache.org>
Subject [GitHub] cordova-plugin-inappbrowser pull request #205: CB-9148 - (android) Add suppo...
Date Tue, 03 Jan 2017 18:09:09 GMT
Github user infil00p commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/205#discussion_r94452235
  
    --- Diff: src/android/InAppBrowser.java ---
    @@ -832,6 +889,42 @@ private void sendUpdate(JSONObject obj, boolean keepCallback, PluginResult.Statu
         }
     
         /**
    +     * Receive File Data from File Chooser
    +     *
    +     * @param requestCode the requested code from chromeclient
    +     * @param resultCode the result code returned from android system
    +     * @param intent the data from android file chooser
    +     */
    +    public void onActivityResult(int requestCode, int resultCode, Intent intent) {
    +        // For Android >= 5.0
    +        if(Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP) {
    +            Log.i("mytag", "onActivityResult (For Android >= 5.0)");
    +            // If RequestCode or Callback is Invalid
    +            if(requestCode != FILECHOOSER_REQUESTCODE_LOLLIPOP || mUploadCallbackLollipop
== null) {
    +                super.onActivityResult(requestCode, resultCode, intent);
    +                return;
    +            }
    +            mUploadCallbackLollipop.onReceiveValue(WebChromeClient.FileChooserParams.parseResult(resultCode,
intent));
    --- End diff --
    
    Is there a reason that the indenting is broken here? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message