Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 83CD1200BE5 for ; Sat, 10 Dec 2016 00:26:56 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 82550160B1E; Fri, 9 Dec 2016 23:26:56 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id CCAC7160B1D for ; Sat, 10 Dec 2016 00:26:55 +0100 (CET) Received: (qmail 29970 invoked by uid 500); 9 Dec 2016 23:26:55 -0000 Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list dev@cordova.apache.org Received: (qmail 29954 invoked by uid 99); 9 Dec 2016 23:26:54 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 09 Dec 2016 23:26:54 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 9DFE2E02A3; Fri, 9 Dec 2016 23:26:54 +0000 (UTC) From: filmaj To: dev@cordova.apache.org Reply-To: dev@cordova.apache.org Message-ID: Subject: [GitHub] cordova-plugin-contacts pull request #143: Jasmine use of `afterAll` and lab... Content-Type: text/plain Date: Fri, 9 Dec 2016 23:26:54 +0000 (UTC) archived-at: Fri, 09 Dec 2016 23:26:56 -0000 GitHub user filmaj opened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/143 Jasmine use of `afterAll` and label tweaks ### Platforms affected iOS and Android ### What does this PR do? Instead of encapsulating teardown functionality into a jasmine test case via `it`, use the `afterAll` teardown function to specify one-time cleanup tasks. ### What testing has been done on this change? Tested on Android 5.1 emulator. ### Checklist - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/filmaj/cordova-plugin-contacts appium-test-tweaks Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-contacts/pull/143.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #143 ---- commit 0153e093689db952846621fc14fa2bd7f17cfd49 Author: filmaj Date: 2016-12-09T23:22:35Z Pulled out appium session destruction into a jasmine `afterAll` teardown function (instead of its own test). Tweaking some labels. ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org For additional commands, e-mail: dev-help@cordova.apache.org