Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
From: audreyso <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-510-cordova-lib@git.apache.org>
In-Reply-To: <git-pr-510-cordova-lib@git.apache.org>
Subject: [GitHub] cordova-lib pull request #510: Fixjasmine : CB:12018 - updating tests in cor...
Content-Type: text/plain
Message-Id: <20161221183352.5581EDFCE0@git1-us-west.apache.org>
Date: Wed, 21 Dec 2016 18:33:52 +0000 (UTC)
archived-at: Wed, 21 Dec 2016 18:33:54 -0000

Github user audreyso commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/510#discussion_r93493946
  
    --- Diff: cordova-lib/spec-plugman/platforms/ios.spec.js ---
    @@ -301,14 +301,8 @@ describe('ios project handler', function() {
                 });
             });
             it('of two plugins should apply xcode file changes from both', function(){
    --- End diff --
    
    @stevengill : if I modify this test, the console.logs both print out, but there are 3 failures.
    
    ``` it('of two plugins should apply xcode file changes from both', function(done){
                 install('ios', temp, dummyplugin)
                .then(function (result) { 
                    var xcode = ios.parseProjectFile(temp).xcode;
                    // from org.test.plugins.dummyplugin
                    expect(xcode.hasFile(slashJoin('Resources', 'DummyPlugin.bundle'))).toBeTruthy();
                    expect(xcode.hasFile(slashJoin('Plugins','org.test.plugins.dummyplugin', 'DummyPluginCommand.h'))).toBeTruthy();
                    expect(xcode.hasFile(slashJoin('Plugins','org.test.plugins.dummyplugin', 'DummyPluginCommand.m'))).toBeTruthy();
                    expect(xcode.hasFile(slashJoin('Plugins','org.test.plugins.dummyplugin','targetDir','TargetDirTest.h'))).toBeTruthy();
                    expect(xcode.hasFile(slashJoin('Plugins','org.test.plugins.dummyplugin','targetDir','TargetDirTest.m'))).toBeTruthy();
                    expect(xcode.hasFile(slashJoin('SampleApp','Plugins','org.test.plugins.dummyplugin','Custom.framework'))).toBeTruthy();
                    console.log('done 1')
                }).then(function (result) {
                    install('ios', temp, weblessplugin)
                }).then(function (result) {
                    var xcode = ios.parseProjectFile(temp).xcode;
                    // from org.test.plugins.weblessplugin
                    // Below fails and wants false
                    expect(xcode.hasFile(slashJoin('Resources', 'WeblessPluginViewController.xib'))).toBeTruthy();
                    // Below fails and wants false
                    expect(xcode.hasFile(slashJoin('Plugins','org.test.plugins.weblessplugin','WeblessPluginCommand.h'))).toBeTruthy();
                    // Below fails and wants false
                    expect(xcode.hasFile(slashJoin('Plugins','org.test.plugins.weblessplugin','WeblessPluginCommand.m'))).toBeTruthy();
                    expect(xcode.hasFile('usr/lib/libsqlite3.dylib')).toBeTruthy();
                    console.log('done 2')
                });
                done();
            });
        }); ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org