Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
From: stevengill <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-510-cordova-lib@git.apache.org>
In-Reply-To: <git-pr-510-cordova-lib@git.apache.org>
Subject: [GitHub] cordova-lib pull request #510: Fixjasmine : CB:12018 - updating tests in cor...
Content-Type: text/plain
Message-Id: <20161221182539.E59B9DFCE0@git1-us-west.apache.org>
Date: Wed, 21 Dec 2016 18:25:39 +0000 (UTC)
archived-at: Wed, 21 Dec 2016 18:25:42 -0000

Github user stevengill commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/510#discussion_r93492132
  
    --- Diff: cordova-lib/spec-plugman/platforms/windows.spec.js ---
    @@ -50,18 +50,30 @@ function copyArray(arr) {
     }
     
     beforeEach(function () {
    -    this.addMatchers({
    +    jasmine.addMatchers({
             toContainXmlPath: function (xpath) {
                 var xml = this.actual;
                 var notText = this.isNot ? 'not ' : '';
    -            this.message = function () {
    -                return 'Expected xml \'' + et.tostring(xml) + '\' ' + notText + 'to contain elements matching \'' + xpath + '\'.';
    -            };
    -
    -            return xml.find(xpath) !== null;
    -        }    });
    +            // this.message = function () {
    +            //     return 'Expected xml \'' + et.tostring(xml) + '\' ' + notText + 'to contain elements matching \'' + xpath + '\'.';
    +            // };
    +            return {
    +                compare: function(actual, expected) {
    +                    var result = {};
    +                    result.pass = fs.existsSync(actual);
    +
    +            //return xml.find(xpath) !== null;
    +                    if(result.pass) {
    +                        result.message = "expected " + actual + " to not exist";
    +                    } else {
    +                        result.message = "expected " + actual + " to exist";
    --- End diff --
    
    update second message to 
    
    `'Expected xml \'' + et.tostring(xml) + '\' ' +' to contain elements matching \'' + expected + '\'.';`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org