Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
From: daserge <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-219-cordova-windows@git.apache.org>
In-Reply-To: <git-pr-219-cordova-windows@git.apache.org>
Subject: [GitHub] cordova-windows pull request #219: CB-12189: Add support for WinMD and DLL c...
Content-Type: text/plain
Message-Id: <20161221155701.D9054DFB86@git1-us-west.apache.org>
Date: Wed, 21 Dec 2016 15:57:01 +0000 (UTC)
archived-at: Wed, 21 Dec 2016 15:57:04 -0000

Github user daserge commented on a diff in the pull request:

    https://github.com/apache/cordova-windows/pull/219#discussion_r93460566
  
    --- Diff: template/cordova/lib/PluginInfo.js ---
    @@ -115,6 +115,33 @@ function PluginInfo(dirname) {
             var configFiles = parentGetConfigFiles(platform);
             return processChanges(configFiles);
         };
    +
    +    this.getFrameworks = function(platform) {
    --- End diff --
    
    nit: [outdated comment](https://github.com/apache/cordova-windows/pull/219/files#diff-93a26ea6e269125a5b151c4176a3b42bL100)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org