Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 9017E200BE2 for ; Thu, 15 Dec 2016 13:55:56 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 8EA17160B30; Thu, 15 Dec 2016 12:55:56 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 0A02D160B0B for ; Thu, 15 Dec 2016 13:55:55 +0100 (CET) Received: (qmail 26376 invoked by uid 500); 15 Dec 2016 12:55:55 -0000 Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list dev@cordova.apache.org Received: (qmail 26329 invoked by uid 99); 15 Dec 2016 12:55:54 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 15 Dec 2016 12:55:54 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id AF635E7DFC; Thu, 15 Dec 2016 12:55:54 +0000 (UTC) From: vladimir-kotikov To: dev@cordova.apache.org Reply-To: dev@cordova.apache.org References: In-Reply-To: Subject: [GitHub] cordova-windows pull request #216: CB-11177 SplashScreen gets shifted on Win... Content-Type: text/plain Message-Id: <20161215125554.AF635E7DFC@git1-us-west.apache.org> Date: Thu, 15 Dec 2016 12:55:54 +0000 (UTC) archived-at: Thu, 15 Dec 2016 12:55:56 -0000 Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/216#discussion_r92603101 --- Diff: cordova-js-src/splashscreen.js --- @@ -148,29 +152,27 @@ function init(config, manifest) { extendedSplashProgress.classList.add('win-medium'); extendedSplashProgress.classList.add('win-ring'); + extendedSplashImage.style.maxWidth = "100%"; + extendedSplashImage.style.maxHeight = "100%"; + extendedSplashImage.src = splashImageSrc; + if (isWp81 || isWp10) { - extendedSplashImage.style.maxWidth = "100%"; - extendedSplashImage.style.maxHeight = "100%"; - extendedSplashImage.src = splashImageSrc; // center horizontally extendedSplashImage.style.margin = "0 auto"; - extendedSplashImage.style.display = "block"; + extendedSplashImage.style.display = "inline-block"; --- End diff -- Can we move this to CSS using the same technique as for `extendedSplashProgress` (additional css classes based on whether we're running on desktop/phone)? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org For additional commands, e-mail: dev-help@cordova.apache.org