Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
From: audreyso <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-510-cordova-lib@git.apache.org>
In-Reply-To: <git-pr-510-cordova-lib@git.apache.org>
Subject: [GitHub] cordova-lib pull request #510: Fixjasmine : CB:12018 - updating tests in cor...
Content-Type: text/plain
Message-Id: <20161214201848.24AD3F169E@git1-us-west.apache.org>
Date: Wed, 14 Dec 2016 20:18:48 +0000 (UTC)
archived-at: Wed, 14 Dec 2016 20:18:55 -0000

Github user audreyso commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/510#discussion_r92480348
  
    --- Diff: cordova-common/spec/CordovaCheck.spec.js ---
    @@ -30,11 +30,12 @@ describe('findProjectRoot method', function() {
             process.env.PWD = origPWD;
             process.chdir(cwd);
         });
    +function removeDir(someDirectory) {
    +    shell.rm('-rf', someDirectory);
    +}
         it('should return false if it hits the home directory', function() {
             var somedir = path.join(home, 'somedir');
    -        this.after(function() {
    --- End diff --
    
    Here does this.after remove the somedir similarly to how we are using in for testing save/fetch? In the beforeEach, I have ``` shell.rm('-rf', project); ``` to clear the previous temp project? Maybe I should just use my function in a beforeEach?  But then how will the someDir get updated if it changes from test to test? (if that makes sense)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org