Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
From: alsorokin <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-143-cordova-plugin-contacts@git.apache.org>
In-Reply-To: <git-pr-143-cordova-plugin-contacts@git.apache.org>
Subject: [GitHub] cordova-plugin-contacts pull request #143: Jasmine use of `afterAll` and lab...
Content-Type: text/plain
Message-Id: <20161214075905.84B0DE3813@git1-us-west.apache.org>
Date: Wed, 14 Dec 2016 07:59:05 +0000 (UTC)
archived-at: Wed, 14 Dec 2016 07:59:08 -0000

Github user alsorokin commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-contacts/pull/143#discussion_r92337971
  
    --- Diff: appium-tests/common/common.spec.js ---
    @@ -242,7 +248,6 @@ describe('Contacts Android', function () {
     
         describe('Picking contacts', function () {
             afterEach(function (done) {
    -            checkSession(done);
    --- End diff --
    
    I think it is still needed in `afterEach` so we wouldn't try to remove test contacts (which means calling driver's methods) after a skipped spec.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org