Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
From: jcesarmobile <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-197-cordova-plugin-inappbrowser@git.apache.org>
In-Reply-To: <git-pr-197-cordova-plugin-inappbrowser@git.apache.org>
Subject: [GitHub] cordova-plugin-inappbrowser pull request #197: CB-12132: (android & ios) imp...
Content-Type: text/plain
Message-Id: <20161201233553.16E19DFC47@git1-us-west.apache.org>
Date: Thu,  1 Dec 2016 23:35:53 +0000 (UTC)
archived-at: Thu, 01 Dec 2016 23:35:56 -0000

Github user jcesarmobile commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/197#discussion_r90560844
  
    --- Diff: src/ios/CDVInAppBrowser.m ---
    @@ -568,7 +576,11 @@ - (void)createViews
         self.spinner.userInteractionEnabled = NO;
         [self.spinner stopAnimating];
     
    -    self.closeButton = [[UIBarButtonItem alloc] initWithBarButtonSystemItem:UIBarButtonSystemItemDone target:self action:@selector(close)];
    +    if (_browserOptions.hidenotclose != nil) {
    --- End diff --
    
    This shows a warning 
    > Comparison between pointer and integer ('int' and 'void *')
    
    Take a look how the other options are parsed and converted to booleans and do the same so you can use `if (browserOptions.hidenotclose)`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org