cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From alsorokin <>
Subject [GitHub] cordova-plugin-screen-orientation pull request #9: CB-12286 Tests reworked
Date Wed, 21 Dec 2016 12:09:52 GMT
GitHub user alsorokin opened a pull request:

    CB-12286 Tests reworked

    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    ### Platforms affected
    ### What does this PR do?
    Tests now actually verify the plugin's methods and properties instead of the native built-in
    ### What testing has been done on this change?
    Paramedic run on Android and Windows.
    ### Checklist
    - [x] [Reported an issue]( in the JIRA
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [x] Added automated test coverage as appropriate for this change.

You can merge this pull request into a Git repository by running:

    $ git pull CB-12286

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #9
commit cd2ee4666d66190424df4efc9291c31be6d4781b
Author: Alexander Sorokin <>
Date:   2016-12-21T11:46:01Z

    CB-12286 Tests reworked


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message