cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From alsorokin <...@git.apache.org>
Subject [GitHub] cordova-plugin-screen-orientation pull request #8: CB-12285 Polyfill promise...
Date Wed, 21 Dec 2016 09:16:04 GMT
GitHub user alsorokin opened a pull request:

    https://github.com/apache/cordova-plugin-screen-orientation/pull/8

    CB-12285 Polyfill promises on platforms that doesn't support them nat…

    …ively
    
    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    All platforms with webview that doesn't support promises natively. For example, Android
API level 19.
    
    ### What does this PR do?
    Includes a polyfill library so the promises (and therefore, `.lockScreen` function) would
work everywhere.
    
    ### What testing has been done on this change?
    Paramedic tests on Android API 19.
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/alsorokin/cordova-plugin-screen-orientation CB-12285

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-screen-orientation/pull/8.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #8
    
----
commit 4ab51641c26af31a08ebe578b33ad02a2e07093d
Author: Alexander Sorokin <alexander.sorokin@akvelon.com>
Date:   2016-12-21T09:10:19Z

    CB-12285 Polyfill promises on platforms that doesn't support them natively

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message