cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ktop <...@git.apache.org>
Subject [GitHub] cordova-lib pull request #509: CB-12163 Add reference attrib to resource-fil...
Date Tue, 13 Dec 2016 17:55:21 GMT
GitHub user ktop opened a pull request:

    https://github.com/apache/cordova-lib/pull/509

    CB-12163 Add reference attrib to resource-file for Windows

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    cordova-common for Windows
    
    ### What does this PR do?
    Adds a new attribute to the resource-file tag for Windows. The attribute is for moving
the current functionality of "referencing files" to be switched on by this flag in order to
bring back the copy functionality to be default for resource-file. 
    
    ex. 
    ```
    <resource-file src="x86/foo.dll" target="foo.dll" arch="x86" reference="true" />
    <resource-file src="x64/foo.dll" target="foo.dll" arch="x64" reference="true" />
    ```
    
    ### What testing has been done on this change?
    Manual testing and unit testing. Need to pull in changes from the cordova-windows pull
request to get it to work properly. 
    
    ### Checklist
    - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [X] Added automated test coverage as appropriate for this change.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ktop/cordova-lib cb12163

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-lib/pull/509.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #509
    
----
commit 9d69d3df1d765ad9c05ece48864fc47c6c3e7061
Author: ktop <ktop500@gmail.com>
Date:   2016-12-12T19:35:04Z

    CB-12163 Add reference attrib to resource-file for Windows

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message