cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ktop <>
Subject [GitHub] cordova-lib pull request #508: CB-11908 Add tests for edit-config in config....
Date Tue, 13 Dec 2016 17:46:20 GMT
GitHub user ktop opened a pull request:

    CB-11908 Add tests for edit-config in config.xml and fix typo

    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    ### Platforms affected
    ### What does this PR do?
    I had this commit ready to go, but forgot to commit and push it. Here I'm adding tests
for the 'edit-config' functionality that was added to config.xml. 
    ### What testing has been done on this change?
    Manual tests and adding unit tests. 
    ### Checklist
    - [x ] [Reported an issue]( in the JIRA
    - [x ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [x ] Added automated test coverage as appropriate for this change.

You can merge this pull request into a Git repository by running:

    $ git pull editconfigxml

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #508
commit aa4c6e8380c6e5edf1bf20a508b450e64a1d6e7c
Author: ktop <>
Date:   2016-12-09T19:53:50Z

    CB-11908 Add tests for edit-config in config.xml and fix typo
    Add one more test case


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message