cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From daserge <...@git.apache.org>
Subject [GitHub] cordova-android pull request #354: CB-12099 (android) SplashScreen Screen Fl...
Date Tue, 27 Dec 2016 12:38:47 GMT
GitHub user daserge opened a pull request:

    https://github.com/apache/cordova-android/pull/354

    CB-12099 (android) SplashScreen Screen Flicker

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    Android
    
    ### What does this PR do?
    Introduced new SplashScreenBackgroundColor preference.
    Platform will now use it or BackgroundColor or BLACK color as Activity.windowBackground
to avoid black flash on start.
    Added semver to dependencies (taken bundled version from common, so bundle change isn't
required).
    
    ### What testing has been done on this change?
    Manual and auto tests
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/daserge/cordova-android CB-12099

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-android/pull/354.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #354
    
----
commit 4a2f60cba3b594570996e89730cdea69243efef7
Author: daserge <v-seshak@microsoft.com>
Date:   2016-12-16T17:58:09Z

    CB-12099 (android) SplashScreen Screen Flicker
    Introduced new SplashScreenBackgroundColor preference.
    Platform will now use it or BackgroundColor or BLACK color as Activity.windowBackground
to avoid black flash on start.
    Added semver to dependencies (taken bundled version from common, so bundle change isn't
required).

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message