cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fkoester <...@git.apache.org>
Subject [GitHub] cordova-plugin-wkwebview-engine pull request #25: Feature: Allow to configur...
Date Thu, 08 Dec 2016 09:12:36 GMT
GitHub user fkoester opened a pull request:

    https://github.com/apache/cordova-plugin-wkwebview-engine/pull/25

    Feature: Allow to configure navigation by gestures

    ### Platforms affected
    All iOS devices supporting the WKWebView.
    
    ### What does this PR do?
    This PR adds a new configuration option `AllowBackForwardNavigationGestures`, which is
disabled by default. You can enable it in your `config.xml` via:
    
    ```xml
    <preference name="AllowBackForwardNavigationGestures" value="true" />
    ```
    
    Afterwards, the navigation gestures for forward/backward are enabled in the WebView (aka
"Swipe Navigation").
    
    ### What testing has been done on this change?
    * I tested it without this preference set => swipe navigation disabled like before
(backwards compatability)
    * I tested it with the preference set to `true` like above => swipe navigation enabled.
You can swipe back and forward like in Safari.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/fkoester/cordova-plugin-wkwebview-engine swipe-navigation

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-wkwebview-engine/pull/25.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #25
    
----
commit 036b7429ec9348e19ceada72df3e7c993e0050a5
Author: Fabian Köster <mail@fabian-koester.com>
Date:   2016-12-08T09:01:24Z

    Allow to configure navigation by gestures
    
    This adds a new configuration option "AllowBackForwardNavigationGestures":
    
    When enabled, the navigation gestures for forward/backward are enabled (aka "Swipe Navigation")

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message