cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From filmaj <...@git.apache.org>
Subject [GitHub] cordova-plugin-camera pull request #244: Android Appium test tweaks
Date Fri, 16 Dec 2016 22:37:33 GMT
GitHub user filmaj opened a pull request:

    https://github.com/apache/cordova-plugin-camera/pull/244

    Android Appium test tweaks

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    
    Android
    
    ### What does this PR do?
    
    - updated comments on how to run the tests.
    - extra comments around functionality at certain points in the automation.
    - stub of a resolution checker on test startup - still need to figure out acceptable values.
    - moved session shutdown to an `afterAll` clause. 
    - changed resolution determiner from using webview-based values to using the native windows
dimensions. this helps as the webview values may be scaled down intentionally by manufacturers
(via changing `window.devicePixelRatio`, for example). furthermore, since the screen dimensions
are used purely for native UI automation using direct coordinates, better to use the dimensions
reported by the native context rather than the web context.
    - removed duplicate element calls.
    
    ### What testing has been done on this change?
    
    Tested on local appium 1.6.3 environment on Android 4.4 and 5.1 stock emulators.
    
    ### Checklist
    - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/filmaj/cordova-plugin-camera android-appium-tweaks

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-camera/pull/244.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #244
    
----
commit f4616d88cd1b87433f0f8b98a1d228253be461aa
Author: filmaj <maj.fil@gmail.com>
Date:   2016-12-16T22:33:59Z

    [Appium] [Android] updated comments on how to run the tests. extra comments around functionality
at certain points in the automation. stub of a resolution checker on test startup - still
need to figure out acceptable values. moved session shutdown to an afterAll clause. changed
resolution determiner from using webview-based values to using the native windows dimensions
- this helps as the webview values may be scaled down intentionally by manufacturers (via
changing devicePixelRatio). furthermore, since the screen dimension automation is used purely
for native UI automation, better to use the dimensions reported by the native context rather
than the web context. removed duplicate element calls.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message