cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Webpal <...@git.apache.org>
Subject [GitHub] cordova-plugin-camera pull request #243: Double exif rotation on android wit...
Date Fri, 16 Dec 2016 13:36:56 GMT
GitHub user Webpal opened a pull request:

    https://github.com/apache/cordova-plugin-camera/pull/243

    Double exif rotation on android with camera

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    
    
    ### What does this PR do?
    
    
    ### What testing has been done on this change?
    
    
    ### Checklist
    - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.
    
    This solves the "correctOrientation not rotating / wrong orientation with Android camera
bug"
    
    If flag correctOrientation is set the image is rotated according to EXIF-data. After this,
the original EXIF-data is added back to the image where the rotation is stil there. Result
is that instead of a wrongly rotated image with EXIF-data to correct you end up with a correctly
rotated image with EXIF-data that tilts the image 90 degrees.
    
    Removing the EXIF completely solves this for me - there should be a more elegant solution
to just remove the "orientation" data from the EXIF to make this a more general purpose solution.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Webpal/cordova-plugin-camera patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-camera/pull/243.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #243
    
----
commit 60853d620f713651eaa2f82cf2b329b6c7730d21
Author: Webpal <niklas@webpal.se>
Date:   2016-12-16T13:35:11Z

    Double exif rotation on android with camera
    
    This solves the "correctOrientation not rotating / wrong orientation with Android camera
bug"
    
    If flag correctOrientation is set the image is rotated according to EXIF-data. After this,
the original EXIF-data is added back to the image where the rotation is stil there. Result
is that instead of a wrongly rotated image with EXIF-data to correct you end up with a correctly
rotated image with EXIF-data that tilts the image 90 degrees.
    
    Removing the EXIF completely solves this for me - there should be a more elegant solution
to just remove the "orientation" data from the EXIF to make this a more general purpose solution.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message