cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vladimir-kotikov <...@git.apache.org>
Subject [GitHub] cordova-windows pull request #217: CB-12239 Add buildFlag option similar to ...
Date Tue, 13 Dec 2016 10:07:09 GMT
GitHub user vladimir-kotikov opened a pull request:

    https://github.com/apache/cordova-windows/pull/217

    CB-12239 Add buildFlag option similar to iOS

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### What does this PR do?
    
    This PR adds `buildFlag` CLI argument and corresponding option for `build.json` file (similar
to iOS) to allow users to pass arbitrary options directly to MSBuild
    
    
    ### What testing has been done on this change?
    
    Added new tests, ran unit and e2e tests
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [x] Added automated test coverage as appropriate for this change.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vladimir-kotikov/cordova-windows build-flags-support

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-windows/pull/217.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #217
    
----
commit 6308e6974f5499857254fb79c91ded422b46486f
Author: Vladimir Kotikov <kotikov.vladimir@gmail.com>
Date:   2016-12-12T15:45:51Z

    CB-12239 Add buildFlag option similar to iOS

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message