cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From daserge <...@git.apache.org>
Subject [GitHub] cordova-windows pull request #215: CB-12193 cordova.js crashes windows app i...
Date Fri, 09 Dec 2016 15:45:28 GMT
GitHub user daserge opened a pull request:

    https://github.com/apache/cordova-windows/pull/215

    CB-12193 cordova.js crashes windows app if there is no CoreWindow

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    Windows
    
    ### What does this PR do?
    Don't subscribe to WinRT lifecycle events Cordova is running in webview.
    Also made confighelper to load after WinJS as it depends on it.
    [CB-12193](https://issues.apache.org/jira/browse/CB-12193)
    
    ### What testing has been done on this change?
    Manual tests.
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/daserge/cordova-windows CB-12193

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-windows/pull/215.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #215
    
----
commit 707bf962823b9585a22dfaa3ffa6f0185562df5a
Author: daserge <v-seshak@microsoft.com>
Date:   2016-12-08T14:53:11Z

    CB-12193 cordova.js crashes windows app if there is no CoreWindow
    Also made confighelper to load after WinJS as it depends on it

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message