cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ktop <...@git.apache.org>
Subject [GitHub] cordova-windows pull request #213: CB-12163 Make resource-file copy files ag...
Date Tue, 06 Dec 2016 21:12:51 GMT
GitHub user ktop opened a pull request:

    https://github.com/apache/cordova-windows/pull/213

    CB-12163 Make resource-file copy files again

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    - Windows
    
    ### What does this PR do?
    - Revert the functionality of resource-file in plugin.xml. It will now copy files again
instead of using the references. 
    
    ### What testing has been done on this change?
    - Updated the spec tests and ran them
    - Created a new app with the updated resource-file and check to see if it copies files.

    
    ### Checklist
    - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [X] Added automated test coverage as appropriate for this change.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ktop/cordova-windows cb12163

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-windows/pull/213.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #213
    
----
commit d00e0c33d388f410d6444920d72b7ac1e86df3ef
Author: ktop <ktop500@gmail.com>
Date:   2016-12-06T20:58:42Z

    CB-12163 Make resource-file copy files again

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message