cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gorebar <...@git.apache.org>
Subject [GitHub] cordova-plugin-inappbrowser pull request #201: (Android) Implement Download ...
Date Mon, 12 Dec 2016 11:53:24 GMT
GitHub user Gorebar opened a pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/201

    (Android) Implement Download Files from URL on Android WebView.

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    
    Android
    
    ### What does this PR do?
    
    Allow Download Files from URL on Android WebView
    
    ### What testing has been done on this change?
    
    Download Files from URL.
    
    ### Checklist
    - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.
    
    I needed download files from URL on Android WebView but doesn't works, then... I added
`inAppWebView.setDownloadListener` method to implement that feature. Testes on Android 4.4
and above and works fine. =)
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Gorebar/cordova-plugin-inappbrowser master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/201.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #201
    
----
commit 4063179c35bbd6c4bd1f3deaef005fd2c95fe36b
Author: Gorebar <alba37@telefonica.net>
Date:   2016-12-12T11:49:19Z

    (Android) Implement Download Files from URL on Android WebView.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message