cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From meirotstein <...@git.apache.org>
Subject [GitHub] cordova-plugin-contacts pull request #145: CB-12300: fix tests failure when ...
Date Mon, 26 Dec 2016 14:34:02 GMT
GitHub user meirotstein opened a pull request:

    https://github.com/apache/cordova-plugin-contacts/pull/145

    CB-12300: fix tests failure when running it using jasmine-node

    ### Platforms affected
    None
    
    ### What does this PR do?
    This PR allows to run this project jasmine tests using [jasmine-node](https://github.com/mhevery/jasmine-node)
    In nodejs convention when calling async test done() function with parameter it consider
it as error object and the test fails.
    In this project on the following tests the done function is eventually called with a parameter:
    contacts.spec.25
    contacts.spec.28
    contacts.spec.29
    
    If you'll run these tests with jasmine-node you'll get the following error:
    `Message:
         [object Object]
       Stacktrace:
         undefined`
    
     This PR fixes it by sending own callback that calls done as expected
    
    ### What testing has been done on this change?
    Run the test :)
    
    ### Checklist
    - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [X] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/meirotstein/cordova-plugin-contacts master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-contacts/pull/145.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #145
    
----
commit 8843cd3f04205cb2be6b57ccae6fd3ec804410f2
Author: Meir Rotstein <meir@rotstein.co.il>
Date:   2016-12-26T14:14:44Z

    fix tests failure when running it using jasmine-node

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message