cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From filmaj <...@git.apache.org>
Subject [GitHub] cordova-plugin-contacts pull request #143: Jasmine use of `afterAll` and lab...
Date Fri, 09 Dec 2016 23:26:54 GMT
GitHub user filmaj opened a pull request:

    https://github.com/apache/cordova-plugin-contacts/pull/143

    Jasmine use of `afterAll` and label tweaks 

    ### Platforms affected
    
    iOS and Android
    
    ### What does this PR do?
    
    Instead of encapsulating teardown functionality into a jasmine test case via `it`, use
the `afterAll` teardown function to specify one-time cleanup tasks.
    
    ### What testing has been done on this change?
    
    Tested on Android 5.1 emulator.
    
    ### Checklist
    - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/filmaj/cordova-plugin-contacts appium-test-tweaks

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-contacts/pull/143.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #143
    
----
commit 0153e093689db952846621fc14fa2bd7f17cfd49
Author: filmaj <maj.fil@gmail.com>
Date:   2016-12-09T23:22:35Z

    Pulled out appium session destruction into a jasmine `afterAll` teardown function (instead
of its own test). Tweaking some labels.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message