cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From daserge <...@git.apache.org>
Subject [GitHub] cordova-plugin-splashscreen pull request #121: CB-12099 (android) SplashScre...
Date Tue, 27 Dec 2016 12:39:43 GMT
GitHub user daserge opened a pull request:

    https://github.com/apache/cordova-plugin-splashscreen/pull/121

    CB-12099 (android) SplashScreen Screen Flicker

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    Android
    
    ### What does this PR do?
    Documented new SplashScreenBackgroundColor preference
    Minor version bump
    Requires https://github.com/apache/cordova-android/pull/354 to use `SplashScreenBackgroundColor`;
will fallback to `BackgroundColor` (and to BLACK if it's not set) otherwise.
    
    ### What testing has been done on this change?
    Manual tests
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/daserge/cordova-plugin-splashscreen CB-12099

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-splashscreen/pull/121.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #121
    
----
commit ab12462b4186d77099c5eb20d7fde9fe807017cb
Author: daserge <v-seshak@microsoft.com>
Date:   2016-12-16T17:57:17Z

    CB-12099 (android) SplashScreen Screen Flicker
    Documented new SplashScreenBackgroundColor preference
    Minor version bump

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message