cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Shazron <shaz...@gmail.com>
Subject Re: [DISCUSS] Plugins Release
Date Mon, 12 Dec 2016 23:39:44 GMT
https://issues.apache.org/jira/browse/CB-12224 is complete (published to
dist, npm and blog post is live).

On Mon, Dec 12, 2016 at 10:48 AM, Shazron <shazron@gmail.com> wrote:

> Thanks Carlos and Steve for the access.
> Unfortunately, one last hiccup -- when trying to publish
> `cordova-plugin-screen-orientation` to npm the version already exists
> (the package already existed before Apache, but now we have access). This
> is due to the migration of this plugin repo from a community user -- when
> that happened the version should have been bumped -- our packaging
> automation treats the current version in plugin.xml/package.json as the
> version to be published next.
>
> I'll have to remove it from dist, and move its release to
> https://issues.apache.org/jira/browse/CB-12237
>
>
> On Mon, Dec 12, 2016 at 5:14 AM, Carlos Santana <csantana23@gmail.com>
> wrote:
>
>> Ok Shaz, you have access to all cordova plugins on npm now
>>
>> Keep the good work adn train moving forward shoo shoo !!!
>>
>>
>> On Mon, Dec 12, 2016 at 8:06 AM Carlos Santana <csantana23@gmail.com>
>> wrote:
>>
>> > Shaz giving you access at the moment, should be done in 5 minutes
>> >
>> > On Sun, Dec 11, 2016 at 5:37 PM Shazron <shazron@gmail.com> wrote:
>> >
>> >> Hi Steve Gill and/or Carlos Santana -- please give me write access to
>> >> these
>> >> npm modules below. Publishing is stalled until I get permissions.
>> >>
>> >> cordova-plugin-battery-status
>> >>     csantanapr
>> >>     stevegill
>> >> cordova-plugin-camera
>> >>     csantanapr
>> >>     stevegill
>> >> cordova-plugin-console
>> >>     csantanapr
>> >>     stevegill
>> >> cordova-plugin-contacts
>> >>     csantanapr
>> >>     stevegill
>> >> cordova-plugin-device
>> >>     csantanapr
>> >>     stevegill
>> >> cordova-plugin-device-motion
>> >>     csantanapr
>> >>     stevegill
>> >> cordova-plugin-device-orientation
>> >>     csantanapr
>> >>     stevegill
>> >> cordova-plugin-dialogs
>> >>     csantanapr
>> >>     stevegill
>> >> cordova-plugin-file
>> >>     kotikov.vladimir
>> >>     csantanapr
>> >>     stevegill
>> >> cordova-plugin-file-transfer
>> >>     nikhilkh
>> >>     csantanapr
>> >>     stevegill
>> >> cordova-plugin-geolocation
>> >>     csantanapr
>> >>     stevegill
>> >> cordova-plugin-globalization
>> >>     csantanapr
>> >>     stevegill
>> >> cordova-plugin-legacy-whitelist
>> >>     csantanapr
>> >>     stevegill
>> >> cordova-plugin-media
>> >>     kotikov.vladimir
>> >>     csantanapr
>> >>     stevegill
>> >> cordova-plugin-media-capture
>> >>     csantanapr
>> >>     stevegill
>> >> cordova-plugin-network-information
>> >>     csantanapr
>> >>     stevegill
>> >> cordova-plugin-screen-orientation
>> >>     gbenvenuti
>> >>     stevegill
>> >>     tony--
>> >> cordova-plugin-splashscreen
>> >>     kotikov.vladimir
>> >>     csantanapr
>> >>     stevegill
>> >> cordova-plugin-statusbar
>> >>     kotikov.vladimir
>> >>     csantanapr
>> >>     stevegill
>> >> cordova-plugin-test-framework
>> >>     csantanapr
>> >>     stevegill
>> >> cordova-plugin-vibration
>> >>     csantanapr
>> >>     stevegill
>> >> cordova-plugin-whitelist
>> >>     csantanapr
>> >>     stevegill
>> >>
>> >> --------------
>> >>
>> >> I already have access to these:
>> >>
>> >> cordova-plugin-wkwebview-engine
>> >>     bowserj
>> >>     kotikov.vladimir
>> >>     purplecabbage
>> >>     shazron
>> >>     csantanapr
>> >>     stevegill
>> >> cordova-plugin-inappbrowser
>> >>     csantanapr
>> >>     stevegill
>> >>     kotikov.vladimir
>> >>     sgrebnov
>> >>     shazron
>> >>
>> >>
>> >> On Sun, Dec 11, 2016 at 2:11 PM, Shazron <shazron@gmail.com> wrote:
>> >>
>> >> > I've already started https://issues.apache.org/jira/browse/CB-12237
>> >> >
>> >> > On Sun, Dec 11, 2016 at 2:01 PM, Shazron <shazron@gmail.com>
wrote:
>> >> >
>> >> >> One more issue -- cordova-plugin-inappbrowser, my intent is not
to
>> call
>> >> >> anyone out here (hey I'm the major source of mistakes for this
>> >> release) but
>> >> >> my intent is to fix the problem. The plugin minor version was
>> >> incremented
>> >> >> in plugin.xml to 1.6.0 but not incremented in package.json. Thus
>> when
>> >> the
>> >> >> packaging automation ran, the version had a mismatch, and that
this
>> is
>> >> >> reflected in cordova-plugin-inappbrowser.
>> >> >>
>> >> >> https://github.com/apache/cordova-plugin-inappbrowser/commit
>> >> >> /cfbd3845a893df647ff39ec3c750804d775a0e57
>> >> >>
>> >> >> We should have a version mismatch automation check during release
as
>> >> well
>> >> >> in coho, and/or the tests.
>> >> >>
>> >> >> So now the problem is, I can't publish cordova-plugin-inappbrowser
>> this
>> >> >> release because package.json shows the version is 1.5.1 while
>> >> plugin.xml is
>> >> >> 1.6.0 (1.6.0 is correct).
>> >> >>
>> >> >> I will have to omit cordova-plugin-inappbrowser in this release,
and
>> >> put
>> >> >> out another cordova plugins release which includes:
>> >> >>
>> >> >> 1) Updates in cordova-plugin-battery-status that we discussed
>> >> >> 2) The package.json update in cordova-plugin-inappbrowser (same
>> >> version,
>> >> >> 1.6.0)
>> >> >>
>> >> >>
>> >> >>
>> >> >>
>> >> >>
>> >> >>
>> >> >>
>> >> >> On Sun, Dec 11, 2016 at 11:32 AM, Shazron <shazron@gmail.com>
>> wrote:
>> >> >>
>> >> >>> I screwed up the release notes for each plugin (RELEASENOTES.md)
in
>> >> each
>> >> >>> plugin repo. I'll fix it after release, but will fix it for
the
>> blog
>> >> post:
>> >> >>> https://issues.apache.org/jira/browse/CB-12236
>> >> >>>
>> >> >>> On Thu, Dec 8, 2016 at 9:03 PM, <alsorokin@apache.org>
wrote:
>> >> >>>
>> >> >>>> Just replying to it from my apache address to bump it up
from your
>> >> spam
>> >> >>>> folders, guys. I'll cast my +1 today.
>> >> >>>>
>> >> >>>> -----Original Message-----
>> >> >>>> From: Michael Braude [mailto:mbraude@microsoft.com]
>> >> >>>> Sent: Thursday, December 8, 2016 10:09 PM
>> >> >>>> To: dev@cordova.apache.org
>> >> >>>> Subject: RE: [DISCUSS] Plugins Release
>> >> >>>>
>> >> >>>> Not out of the box, no. We don't use that flag ourselves
in our
>> >> default
>> >> >>>> build.
>> >> >>>>
>> >> >>>> I'm OK with this plan. We can release it with the bug and
do a
>> patch
>> >> >>>> release later with a fix.
>> >> >>>>
>> >> >>>> Thanks,
>> >> >>>> Mike
>> >> >>>>
>> >> >>>> -----Original Message-----
>> >> >>>> From: Shazron [mailto:shazron@gmail.com]
>> >> >>>> Sent: Thursday, December 8, 2016 10:48 AM
>> >> >>>> To: dev@cordova.apache.org
>> >> >>>> Subject: Re: [DISCUSS] Plugins Release
>> >> >>>>
>> >> >>>> > I just found that cordova-plugin-battery-status cannot
be built
>> for
>> >> >>>> windows with --browserify tag.
>> >> >>>>
>> >> >>>> Does this affect any downstream distributions, ie Visual
Studio?
>> >> >>>> IMO:
>> >> >>>> If it does, I cancel the vote, put out a new vote without
the
>> >> >>>> battery-status plugin included.
>> >> >>>> If it doesn't, we can re-release just battery-status with
the fix.
>> >> >>>>
>> >> >>>> On Thu, Dec 8, 2016 at 10:35 AM, Jesse <purplecabbage@gmail.com>
>> >> wrote:
>> >> >>>>
>> >> >>>> > We can either drop it from the release and publish
it after a
>> fix,
>> >> or
>> >> >>>> > just go ahead with the release and do it again next
week.
>> >> >>>> >
>> >> >>>> > Either way, I believe the rest of the vote can proceed,
and this
>> >> >>>> > should not affect the overall release vote.
>> >> >>>> >
>> >> >>>> > I personally lean towards letting it go out, and re-releasing
>> soon,
>> >> >>>> > mainly based on the facts that the battery-status
plugin is one
>> of
>> >> our
>> >> >>>> > less used, and that the browserify workflow is hardly
utilized.
>> >> >>>> >
>> >> >>>> >
>> >> >>>> >
>> >> >>>> >
>> >> >>>> >
>> >> >>>> > @purplecabbage
>> >> >>>> > risingj.com
>> >> >>>> >
>> >> >>>> > On Thu, Dec 8, 2016 at 6:24 AM, <alsorokin@apache.org>
wrote:
>> >> >>>> >
>> >> >>>> > > Hey guys,
>> >> >>>> > >
>> >> >>>> > > I just found that cordova-plugin-battery-status
cannot be
>> built
>> >> for
>> >> >>>> > > windows with --browserify tag.
>> >> >>>> > > Will it hold the Battery Status Plugin release
back or shall
>> we
>> >> just
>> >> >>>> > > do a patch release later?
>> >> >>>> > > https://na01.safelinks.protection.outlook.com/?url=https%3A%
>> >> >>>> 2F%2Fiss
>> >> >>>> > > ues.apache.org%2Fjira%2Fbrowse%2FCB-12227&data=02%7C01%7Cmbr
>> >> >>>> aude%40m
>> >> >>>> > > icrosoft.com%7Ca3be23faade2476077fa08d41f9afb50%7C72f988bf86
>> >> >>>> f141af91
>> >> >>>> > > ab2d7cd011db47%7C1%7C0%7C636168197876884508&sdata=MYVYCuf3W6
>> >> >>>> dOlBZvSr
>> >> >>>> > > y92n%2FnDrZwYYDXSeM2MqQDcWg%3D&reserved=0
>> >> >>>> > >
>> >> >>>> > > --Alex
>> >> >>>> > >
>> >> >>>> > > -----Original Message-----
>> >> >>>> > > From: Shazron [mailto:shazron@gmail.com]
>> >> >>>> > > Sent: Thursday, December 8, 2016 3:56 AM
>> >> >>>> > > To: dev@cordova.apache.org
>> >> >>>> > > Subject: Re: [DISCUSS] Plugins Release
>> >> >>>> > >
>> >> >>>> > > https://na01.safelinks.protection.outlook.com/?url=
>> >> >>>> > > https%3A%2F%2Fissues.apache.org%2Fjira%2Fbrowse%2FCB-
>> >> >>>> > > 12224&data=02%7C01%7Cv-alsoro%40microsoft.com%
>> >> >>>> > > 7C5f9413fa60704ee1ed8708d41f0520d4%7C72f988bf86f141af91ab2d7
>> cd011
>> >> >>>> > > db47%7C1%7C0%7C636167554259114573&sdata=uXe5IbJ2w9v8sNT5WVzJ
>> >> >>>> knWg30n6
>> >> >>>> > > %
>> >> >>>> > > 2BHBDNepSnUSrlJ0%3D&reserved=0
>> >> >>>> > >
>> >> >>>> > > On Mon, Dec 5, 2016 at 5:42 PM, Shazron <shazron@gmail.com>
>> >> wrote:
>> >> >>>> > >
>> >> >>>> > > > Sergey - I reviewed the two PRs.
>> >> >>>> > > > I'll start on the Plugins Release tomorrow
if there are no
>> >> other
>> >> >>>> > issues.
>> >> >>>> > > >
>> >> >>>> > > > On Mon, Dec 5, 2016 at 1:38 AM, Sergey Shakhnazarov
>> (Akvelon) <
>> >> >>>> > > > v-seshak@microsoft.com> wrote:
>> >> >>>> > > >
>> >> >>>> > > >> Hi guys,
>> >> >>>> > > >>
>> >> >>>> > > >> I would be grateful if someone could
take a look at the
>> >> >>>> > > >> file-transfer plugin PRs related to
chunkedMode:
>> >> >>>> > > >> https://na01.safelinks.protect
>> ion.outlook.com/?url=https%3A%
>> >> >>>> 2F%2F
>> >> >>>> > > >> gith
>> >> >>>> > > >> ub.com%2Fapache%2Fcordova-plug
>> in-file-transfer%2Fpull%2F170&
>> >> >>>> data=
>> >> >>>> > > >> 02%7
>> >> >>>> > > >> C01%7Cv-alsoro%40microsoft.com
>> %7C5f9413fa60704ee1ed8708d41f0
>> >> >>>> 520d4
>> >> >>>> > > >> %7C7
>> >> >>>> > > >> 2f988bf86f141af91ab2d7cd011db4
>> 7%7C1%7C0%7C636167554259114573
>> >> >>>> &sdat
>> >> >>>> > > >> a=Yf
>> >> >>>> > > >> Yuv98kQTbK8dmKtCERRqjYxbQqwu5hWouBgiTbRKU%3D&reserved=0
>> >> >>>> > > >> https://na01.safelinks.protect
>> ion.outlook.com/?url=https%3A%
>> >> >>>> 2F%2F
>> >> >>>> > > >> gith
>> >> >>>> > > >> ub.com%2Fapache%2Fcordova-plug
>> in-file-transfer%2Fpull%2F169&
>> >> >>>> data=
>> >> >>>> > > >> 02%7
>> >> >>>> > > >> C01%7Cv-alsoro%40microsoft.com
>> %7C5f9413fa60704ee1ed8708d41f0
>> >> >>>> 520d4
>> >> >>>> > > >> %7C7
>> >> >>>> > > >> 2f988bf86f141af91ab2d7cd011db4
>> 7%7C1%7C0%7C636167554259124586
>> >> >>>> &sdat
>> >> >>>> > > >> a=cF
>> >> >>>> > > >> wArcxOlkl0SiZwO%2BDXNa0V0wK13jdpI9PCPXK21M8%3D&reserved=0
>> >> >>>> > > >> The changes are not breaking:
>> >> >>>> > > >>   for Android we do not force chunkedMode=true
for HTTPS
>> any
>> >> more
>> >> >>>> > (i.e.
>> >> >>>> > > >> if developer passed it as false in the
opts thus overriding
>> >> the
>> >> >>>> > > defaults),
>> >> >>>> > > >>   for iOS we make chunkedMode=true progress
events to be
>> >> >>>> computable.
>> >> >>>> > > >>
>> >> >>>> > > >> Please let me know if you have any questions
or
>> >> considerations.
>> >> >>>> > > >>
>> >> >>>> > > >> Best regards,
>> >> >>>> > > >> Sergey Shakhnazarov.
>> >> >>>> > > >>
>> >> >>>> > > >> -----Original Message-----
>> >> >>>> > > >> From: Shazron [mailto:shazron@gmail.com]
>> >> >>>> > > >> Sent: Thursday, December 1, 2016 22:47
>> >> >>>> > > >> To: dev@cordova.apache.org
>> >> >>>> > > >> Subject: Re: [DISCUSS] Plugins Release
>> >> >>>> > > >>
>> >> >>>> > > >> I've got a ladder, I'll step up.
>> >> >>>> > > >>
>> >> >>>> > > >> On Thu, Dec 1, 2016 at 5:02 AM, Simon
MacDonald <
>> >> >>>> > > >> simon.macdonald@gmail.com>
>> >> >>>> > > >> wrote:
>> >> >>>> > > >>
>> >> >>>> > > >> > Well Steve is in Hawaii for 10
days so someone else will
>> >> have
>> >> >>>> > > >> > to step up for a plugins release.
>> >> >>>> > > >> >
>> >> >>>> > > >> > Simon Mac Donald
>> >> >>>> > > >> >
>> >> https://na01.safelinks.protection.outlook.com/?url=http%3A%2
>> >> >>>> F%2
>> >> >>>> > > >> > Fsim
>> >> >>>> > > >> > onm
>> >> >>>> > > >> > acdonald.com&data=02%7C01%7Cv-seshak%40microsoft.com
>> >> %7Ccdfb6
>> >> >>>> 940
>> >> >>>> > > >> > 2bfb
>> >> >>>> > > >> > 4f9
>> >> >>>> > > >> > e075008d41a22e7ab%7C72f988bf86
>> f141af91ab2d7cd011db47%7C1%7C0
>> >> >>>> %7C
>> >> >>>> > > >> > 6361
>> >> >>>> > > >> > 621
>> >> >>>> > > >> > 84597304603&sdata=ezMgBuVruBF5
>> EOKtscMs%2FDD8Gh9%2B3elC7PrTgz
>> >> >>>> kzi
>> >> >>>> > > >> > 8k%3
>> >> >>>> > > >> > D&r
>> >> >>>> > > >> > eserved=0
>> >> >>>> > > >> >
>> >> >>>> > > >> >
>> >> >>>> > > >> > On Thu, Dec 1, 2016 at 8:00 AM,
julio cesar sanchez
>> >> >>>> > > >> > <jcesarmobile@gmail.com>
wrote:
>> >> >>>> > > >> > > Bump
>> >> >>>> > > >> > >
>> >> >>>> > > >> > > I updated cordova-plugin-media
to work with iOS 10, we
>> >> should
>> >> >>>> > > >> > > release
>> >> >>>> > > >> it.
>> >> >>>> > > >> > > Joe also wanted to release
cordova-plugin-camera.
>> >> >>>> > > >> > >
>> >> >>>> > > >> > > We should do the full plugin
release.
>> >> >>>> > > >> > >
>> >> >>>> > > >> > >
>> >> >>>> > > >> > > 2016-10-28 0:57 GMT+02:00
julio cesar sanchez
>> >> >>>> > > >> > > <jcesarmobile@gmail.com
>> >> >>>> > > >> >:
>> >> >>>> > > >> > >
>> >> >>>> > > >> > >> No, geolocation works
fine on iOS 10, the last commit
>> >> it's
>> >> >>>> > > >> > >> just to allow the customization
of the message.
>> >> >>>> > > >> > >> I think the only one that
doesn't work with iOS 10 is
>> >> media
>> >> >>>> > > >> > >> plugin, I'm going to look
into it this weekend.
>> >> >>>> > > >> > >>
>> >> >>>> > > >> > >> But +1 to doing a release,
I want to merge a commit on
>> >> >>>> > > >> > >> statusbar plugin too,
but was waiting for cordova-ios
>> >> 3.4.0
>> >> >>>> to do it.
>> >> >>>> > > >> > >>
>> >> >>>> > > >> > >>
>> >> >>>> > > >> > >> 2016-10-27 19:53 GMT+01:00
Steven Gill <
>> >> >>>> stevengill97@gmail.com>:
>> >> >>>> > > >> > >>
>> >> >>>> > > >> > >>> I noticed geolocation
needs a release for ios10.
>> Going
>> >> to
>> >> >>>> > > >> > >>> try to do a
>> >> >>>> > > >> > full
>> >> >>>> > > >> > >>> plugins release next
week.
>> >> >>>> > > >> > >>>
>> >> >>>> > > >> > >>> Point me at any PRs
you want reviewed.
>> >> >>>> > > >> > >>>
>> >> >>>> > > >> > >>
>> >> >>>> > > >> > >>
>> >> >>>> > > >> >
>> >> >>>> > > >> > ------------------------------
>> ------------------------------
>> >> >>>> ---
>> >> >>>> > > >> > ----
>> >> >>>> > > >> > -- To unsubscribe, e-mail:
>> >> dev-unsubscribe@cordova.apache.org
>> >> >>>> > > >> > For additional commands, e-mail:
>> >> dev-help@cordova.apache.org
>> >> >>>> > > >> >
>> >> >>>> > > >> >
>> >> >>>> > > >>
>> >> >>>> > > >
>> >> >>>> > > >
>> >> >>>> > >
>> >> >>>> > >
>> >> >>>> > > ------------------------------------------------------------
>> >> >>>> --------
>> >> >>>> > > - To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
>> >> >>>> > > For additional commands, e-mail: dev-help@cordova.apache.org
>> >> >>>> > >
>> >> >>>> > >
>> >> >>>> >
>> >> >>>>
>> >> >>>> ------------------------------------------------------------
>> ---------
>> >> >>>> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
>> >> >>>> For additional commands, e-mail: dev-help@cordova.apache.org
>> >> >>>>
>> >> >>>>
>> >> >>>> ------------------------------------------------------------
>> ---------
>> >> >>>> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
>> >> >>>> For additional commands, e-mail: dev-help@cordova.apache.org
>> >> >>>>
>> >> >>>>
>> >> >>>
>> >> >>
>> >> >
>> >>
>> >
>>
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message