cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jcesarmobile <...@git.apache.org>
Subject [GitHub] cordova-plugin-media pull request #123: Fix getCurrentAmplitude definition, ...
Date Wed, 28 Dec 2016 21:34:48 GMT
Github user jcesarmobile commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-media/pull/123#discussion_r94079923
  
    --- Diff: README.md ---
    @@ -104,7 +104,7 @@ The following constants are reported as the only parameter to the
     
     ### Methods
     
    -- `media.getCurrentAmplitude`: Returns the current position within an audio file.
    +- `media.getCurrentAmplitude`: Returns the current amplitude of the current recording.
    --- End diff --
    
    Because that definition is also wrong, you are not recording, so the "of the current recording"
makes no sense. And all the other function definitions say "within an audio file" or "of an
audio file"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message