cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jcesarmobile <...@git.apache.org>
Subject [GitHub] cordova-plugin-media pull request #123: Fix getCurrentAmplitude definition, ...
Date Wed, 28 Dec 2016 21:20:37 GMT
Github user jcesarmobile commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-media/pull/123#discussion_r94078703
  
    --- Diff: README.md ---
    @@ -104,7 +104,7 @@ The following constants are reported as the only parameter to the
     
     ### Methods
     
    -- `media.getCurrentAmplitude`: Returns the current position within an audio file.
    +- `media.getCurrentAmplitude`: Returns the current amplitude of the current recording.
    --- End diff --
    
    I saw the issue when you created it, but I don't think the new definition is right.
    
    I think it should be "Returns the current amplitude within an audio file." as this is
not a recording, you should also change the other occurrence of "Returns the current amplitude
of the current recording"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message