cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From stevengill <>
Subject [GitHub] cordova-lib pull request #510: Fixjasmine : CB:12018 - updating tests in cor...
Date Wed, 21 Dec 2016 19:46:51 GMT
Github user stevengill commented on a diff in the pull request:
    --- Diff: cordova-lib/spec-plugman/platforms/ios.spec.js ---
    @@ -301,14 +301,8 @@ describe('ios project handler', function() {
             it('of two plugins should apply xcode file changes from both', function(){
    --- End diff --
    in your first comment, you had done outside the promise chain. In your second comment,
you have done in the correct spot. Order shouldn't matter. 

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message