cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From stevengill <...@git.apache.org>
Subject [GitHub] cordova-lib pull request #510: Fixjasmine : CB:12018 - updating tests in cor...
Date Wed, 21 Dec 2016 18:25:39 GMT
Github user stevengill commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/510#discussion_r93492375
  
    --- Diff: cordova-lib/spec-plugman/platforms/wp8.spec.js ---
    @@ -113,22 +113,21 @@ describe('wp8 project handler', function() {
                     fs.writeFileSync(target, 'some bs', 'utf-8');
                     expect(function() {
                         wp8['source-file'].install(source[0], dummyplugin, temp, dummy_id,
null, proj_files);
    -                }).toThrow('"' + target + '" already exists!');
    +                }).toThrow(new Error ('"' + target + '" already exists!'));
                 });
             });
             describe('of <config-changes> elements', function() {
                 beforeEach(function() {
                     shell.cp('-rf', path.join(wp8_project, '*'), temp);
                 });
    -            it('should process and pass the after parameter to graftXML', function ()
{
    -                var graftXML = spyOn(xml_helpers, 'graftXML').andCallThrough();
    -
    -                runs(function () { installPromise(install('wp8', temp, dummyplugin, plugins_dir,
{})); });
    -                waitsFor(function () { return done; }, 'install promise never resolved',
500);
    -                runs(function () {
    +            it('should process and pass the after parameter to graftXML', function (done)
{
    +                var graftXML = spyOn(xml_helpers, 'graftXML').and.callThrough();
    +                return install('wp8', temp, dummyplugin, plugins_dir, {})
    +                .then(function(result) {
    --- End diff --
    
    don't need the result argument here since you don't use it


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message