cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From stevengill <...@git.apache.org>
Subject [GitHub] cordova-lib pull request #510: Fixjasmine : CB:12018 - updating tests in cor...
Date Wed, 21 Dec 2016 18:25:39 GMT
Github user stevengill commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/510#discussion_r93490083
  
    --- Diff: cordova-lib/spec-plugman/platforms/ios.spec.js ---
    @@ -301,14 +301,8 @@ describe('ios project handler', function() {
                 });
             });
             it('of two plugins should apply xcode file changes from both', function(){
    --- End diff --
    
    I think you should add `done` here and call it at the end of the promise. See what happens.

    
    You can also chain the two promises (move 315 into 313). 
    
    Add some console logs to confirm these tests are actually running


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message