cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From daserge <...@git.apache.org>
Subject [GitHub] cordova-windows pull request #219: CB-12189: Add support for WinMD and DLL c...
Date Wed, 21 Dec 2016 15:57:01 GMT
Github user daserge commented on a diff in the pull request:

    https://github.com/apache/cordova-windows/pull/219#discussion_r93464493
  
    --- Diff: spec/unit/pluginHandler/windows.spec.js ---
    @@ -304,6 +309,47 @@ describe('windows project handler', function () {
                     xpath = 'Reference[@Include="dummy6"]/HintPath';
                     validateInstalledProjects('framework', frameworks[5], xpath, ['windows',
'windows10', 'phone']);
                 });
    +
    +            it('with .winmd and .dll files', function() {
    --- End diff --
    
    Does this spec check that dll files have been actually copied? ([according to this](https://github.com/apache/cordova-windows/pull/219/files#diff-7bcd02ec7f03ffbb25512bd1f4a0d388R99))


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message