cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From audreyso <...@git.apache.org>
Subject [GitHub] cordova-lib pull request #510: Fixjasmine : CB:12018 - updating tests in cor...
Date Thu, 15 Dec 2016 21:48:29 GMT
Github user audreyso commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/510#discussion_r92707427
  
    --- Diff: cordova-lib/spec-cordova/build.spec.js ---
    @@ -67,7 +67,7 @@ describe('build command', function() {
         describe('success', function() {
             it('should run inside a Cordova-based project with at least one added platform
and call both prepare and compile', function(done) {
                 cordova.raw.build(['android','ios']).then(function() {
    -                var opts = {verbose: false, platforms: ['android', 'ios'], options: []};
    +                var opts = Object({ platforms: [ 'android', 'ios' ], verbose: false,
options: Object({  }) })
    --- End diff --
    
    Wasn't sure about this change because the expect was failing... and expecting what I changed
here


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message