cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vladimir-kotikov <...@git.apache.org>
Subject [GitHub] cordova-windows pull request #216: CB-11177 SplashScreen gets shifted on Win...
Date Thu, 15 Dec 2016 12:55:54 GMT
Github user vladimir-kotikov commented on a diff in the pull request:

    https://github.com/apache/cordova-windows/pull/216#discussion_r92603101
  
    --- Diff: cordova-js-src/splashscreen.js ---
    @@ -148,29 +152,27 @@ function init(config, manifest) {
         extendedSplashProgress.classList.add('win-medium');
         extendedSplashProgress.classList.add('win-ring');
     
    +    extendedSplashImage.style.maxWidth = "100%";
    +    extendedSplashImage.style.maxHeight = "100%";
    +    extendedSplashImage.src = splashImageSrc;
    +
         if (isWp81 || isWp10) {
    -        extendedSplashImage.style.maxWidth = "100%";
    -        extendedSplashImage.style.maxHeight = "100%";
    -        extendedSplashImage.src = splashImageSrc;
             // center horizontally
             extendedSplashImage.style.margin = "0 auto";
    -        extendedSplashImage.style.display = "block";
    +        extendedSplashImage.style.display = "inline-block";
    --- End diff --
    
    Can we move this to CSS using the same technique as for `extendedSplashProgress` (additional
css classes based on whether we're running on desktop/phone)?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message