cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From purplecabbage <>
Subject [GitHub] cordova-paramedic pull request #18: Appium updates for Paramedic
Date Wed, 14 Dec 2016 19:30:18 GMT
Github user purplecabbage commented on a diff in the pull request:
    --- Diff: lib/appium/AppiumRunner.js ---
    @@ -102,6 +102,24 @@ function getConfigPath(appPath) {
         return path.join(appPath, 'config.xml');
    +function installAppiumServer() {
    +    /*
    +     * We install appium in this counter-intuitive way at runtime in order to
    +     * not trigger massive dependency downloads via `npm install` for autotest
    +     * execution. Installing appium only happens in the local-running case, and
    +     * thus is not needed in our CI system. By using this method, we save the CI
    +     * a lot of time.
    +     * ALTERNATIVE: what if paramedic dependencies were installed via `npm install
    +     * --production`, and appium was stuffed into `devDependencies`. That should
    +     * also prevent this problem? 
    --- End diff --
    I agree with @alsorokin here. Can we avoid sacrificing the individual plugin developer
for the sake of the CI server?
    This seems like it's maybe a case where we could/should use a *-connect approach and have
another module that provides the connection to appium.  Or maybe we use feature detection
to poke for the appium module and use it if it's present. ... not sure

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message