cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From alsorokin <...@git.apache.org>
Subject [GitHub] cordova-paramedic pull request #18: Appium updates for Paramedic
Date Wed, 14 Dec 2016 09:17:47 GMT
Github user alsorokin commented on a diff in the pull request:

    https://github.com/apache/cordova-paramedic/pull/18#discussion_r92348958
  
    --- Diff: lib/appium/AppiumRunner.js ---
    @@ -102,6 +102,24 @@ function getConfigPath(appPath) {
         return path.join(appPath, 'config.xml');
     }
     
    +function installAppiumServer() {
    +    /*
    +     * We install appium in this counter-intuitive way at runtime in order to
    +     * not trigger massive dependency downloads via `npm install` for autotest
    +     * execution. Installing appium only happens in the local-running case, and
    +     * thus is not needed in our CI system. By using this method, we save the CI
    +     * a lot of time.
    +     * ALTERNATIVE: what if paramedic dependencies were installed via `npm install
    +     * --production`, and appium was stuffed into `devDependencies`. That should
    +     * also prevent this problem? 
    --- End diff --
    
    That is certainly a viable option, but I'm still reluctant to do so because paramedic
is used not only in CI, but also by people who want to test things quickly and they would
certainly run `npm i` and not `npm i --production` and end up with extra 5 minutes of installation
and 250MB of dependencies which are not used in most cases. Not to mention various npm installation
issues...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message